perf: optimize loading messages in threads#552
Merged
Conversation
de6ff2b to
f1fb954
Compare
ff1dd89 to
b04bf5a
Compare
921c459 to
291545d
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
getNameAndPhotoFromPhoneNumber()andgetThreadParticipants(). The original code was inefficiently querying these values for every message in the thread. Caching the results cut loading time by 50%.Tests performed
According to testing on two of my phones, loading is now 4 times faster compared to v1.4.0.
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).