Skip to content

Print WebView: surface main-frame load errors with a toast #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

Print WebView: surface main-frame load errors with a toast #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/src/main/kotlin/org/fossify/notes/activities/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import android.view.ActionMode
import android.view.Gravity
import android.view.MenuItem
import android.view.inputmethod.EditorInfo
import android.webkit.WebResourceError
import android.webkit.WebResourceRequest
import android.webkit.WebView
import android.webkit.WebViewClient
Expand Down Expand Up @@ -1286,6 +1287,13 @@ class MainActivity : SimpleActivity() {
override fun onPageFinished(view: WebView, url: String) {
createWebPrintJob(view)
}

override fun onReceivedError(view: WebView, request: WebResourceRequest, error: WebResourceError) {
super.onReceivedError(view, request, error)
if (request.isForMainFrame) {
toast(org.fossify.commons.R.string.unknown_error_occurred)
}
}
}

webView.loadData(getPrintableText().replace("#", "%23"), "text/plain", "UTF-8")
Expand Down
Loading