-
Notifications
You must be signed in to change notification settings - Fork 34
Added possibility to set own sorting for each checklist (#81) #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sorting seems to be working fine. That's a clever reuse of per-folder sorting functions :)
I know you put in the effort here but this adds too much flexibility to this option. It's better to move it back into settings and keep it global (as discussed sometime ago!). That’ll keep things simpler, both code-wise and UX-wise. Thanks. |
|
Does it happen to you too? |
|
I'm working on it. |
naveensingh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the bug. Everything else looks good, merging now.
What is it?
Description of the changes in your PR
customSortinglogic from Commons.customSortingin other apps, and "custom sorting" means something different here, I've created helpers with the nameownSorting.moveDoneChecklistItemsto be part ofconfig.sorting, so it's also possible to set it separately for each checklist.config.sorting, similarly as showing items count has been done in Gallery's grouping options.moveDoneChecklistItemsvalue to be a flag in a currentconfig.sorting.Before/After Screenshots/Screen Record
qemu-system-x86_64_1GqMvlYkTT.mp4
Fixes the following issue(s)
Acknowledgement