Bring back, "Edit number before call" option

[avatar1024]

Checklist

• I made sure that there are no existing issues - open or closed - to which I could contribute my information.
• I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
• I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one feature request.
• I have read and understood the contribution guidelines.
• I optionally donated to support the Fossify mission.

Feature description

Using SMT Call / contact it was possible, from the contact card, to long press on a phone number and it proposed the option "Edit number before call". This is no longer there in this fork.

Why do you want this feature?

It allowed to quick modify a number, for e.g. to add country extension if calling from abroad, or to select a different sim card as it brought up the dialling page (see here: #148)

Additional information

No response

[Aga-C]

Are you sure it was in Simple Contacts/Dialer? I've never seen this feature, and I've checked the last versions of Simple Contacts and Simple Dialer, and they didn't have it.

Fossify Phone, same as Simple Dialer, doesn't handle contact cards on itself, they are opened in an app that's set in the system as the default contacts app. Maybe, prior to installing Fossify Contacts you had another contacts' app (not Simple Contacts) set as the default one, and it had this feature?

[avatar1024]

I'm positive it did. I have used Simple Contact (and all SMTs) for a long while and it's easily distinguishable from the other (installed by default) contact app present on my phone.

I've just tried to reinstall SMT Contact (latest version and a few older version) but it now looks different to what it did before (and indeed looks identical to Fossify Contact). The whole contact card in Fossify Contact and in SMT Contact I've just installed looks different to the one I use to have (and just to confirm the contact card in the contact app installed by default on my Phone is also different to what I used to have so I'm definitely sure it wasn't that).

Maybe I'd been running an old version of SMT Contact but that'd be odd as I remember getting F-Droid updates for it.

So I really don't know, but I guess if you fork the code from SMT contact then it means they must have removed that or something really odd is going on. I guess I could just change the title of this post to Add "Edit number before call" option :)

[sphh]

AFAIR this "Edit number before call" used to be a feature of Simple Dialer, which has been (sadly) dropped in one of the updates.

I also miss that very handy feature!

[mezhgano]

Funny, but i want exact opposite thing and can't turn it off.
For some strange reason both Fossify phone and contacts app open dialer screen before actually make a call...

[Aga-C]

@mezhgano In Phone, there is already a request for this: #80. In Contacts, you can already change it in Settings → On contact click.

[mezhgano]

@Aga-C Yes, there is an option, but it doesn't work for me.
Even if i choose On contact click → Call Contact, dialer still opens and i must press green button to make a call...

Only difference is previous steps, let me specify more detailed:

On contact click → View contact details leads to following:
Select Contact tab > Click on contact > Contact Details > Click on number > Dialer > Click on green button > Making Call

On contact click → Call Contact leads to following:
Select Contact tab > Click on contact > Dialer > Click on green button > Making Call

And what even more strange, i have second phone with same app version, where it work like it should, without dialer screen.

Maybe i should create new issue for this.

[naveensingh]

@mezhgano there are two pathways:

• Fossify Contacts has phone permission ➜ Call is initiated directly without dialpad
• Fossify Contacts does not have phone permission ➜ Call must go through the dialpad

If you grant the Phone permission to Fossify Contacts, it will work fine.

[mezhgano]

@naveensingh Yes, now it works, thank you.
Looks like i just blindly denied or forget about phone permission.