Fix InvalidCastException in InMemoryCacheClient.GetAsync<object>() for non-IConvertible types

[Copilot]

• Fix GetValue<T>() in InMemoryCacheClient to not route typeof(object) through Convert.ChangeType
• Add a test to verify GetAsync<object>() works for non-IConvertible types, covering both CloneValues=false and CloneValues=true

Original prompt

---

This section details on the original issue you should resolve

<issue_title>InMemoryCacheClient.GetAsync() throws InvalidCastException for non-IConvertible types</issue_title>
<issue_description>InMemoryCacheClient.CacheEntry.GetValue(). When T is object, it matches the TypeHelper.ObjectType check and routes through Convert.ChangeType(val, typeof(object)), which requires the stored value to implement IConvertible. It should just return the value directly since everything is already an object.

Minimal repro:

using Foundatio.Caching;var cache = new InMemoryCacheClient();// Store a complex object that doesn't implement IConvertibleawait cache.SetAsync("key", new MyData("hello", 42));// This throws: System.InvalidCastException: Object must implement IConvertible.var result = await cache.GetAsync("key");Console.WriteLine(result.Value); // never reachedpublic record MyData(string Name, int Value);
Stack trace:

System.InvalidCastException: Object must implement IConvertible.   at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider)   at Foundatio.Caching.InMemoryCacheClient.CacheEntry.GetValueT   at Foundatio.Caching.InMemoryCacheClient.GetAsyncT
Root cause in CacheEntry.GetValue():

public T GetValue(){    object val = Value;    var t = typeof(T);    // BUG: typeof(object) matches here, falls into Convert.ChangeType    if (t == TypeHelper.BoolType || t == TypeHelper.StringType || ... || t == TypeHelper.ObjectType || t.IsNumeric())        return (T)Convert.ChangeType(val, t);  // throws for non-IConvertible values    ...    return (T)val;  // this path works fine but is never reached for T=object}
Fix: Add an early return before the Convert.ChangeType line:

if (t == TypeHelper.ObjectType)    return (T)val;
Or move ObjectType out of the Convert.ChangeType branch entirely. The direct cast (T)val (which is (object)val) always succeeds and is what the final fallback does anyway.</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes InMemoryCacheClient.GetAsync<object>() throws InvalidCastException for non-IConvertible types #467

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}