fix: abandon queue entry when GetQueueEntryLockAsync throws#509
Merged
Conversation
Previously, if GetQueueEntryLockAsync threw an exception (e.g., network failure in a distributed lock provider), the exception would propagate without abandoning the queue entry, leaving it in-flight until the visibility timeout expired. Now the call is wrapped in a try-catch that logs the error, abandons the entry, and returns JobResult.FromException so the entry is retried promptly. Also updates the GetQueueEntryLockAsync example in docs to use TryAcquireAsync (matching the Task<ILock?> return type) and documents the error handling behavior in the jobs/queues guides and skill file.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan