Resolves #117: Support feeding in the datacenter_id option from start up command to …#134
Merged
apkar merged 4 commits intoFoundationDB:masterfrom Apr 1, 2019
Conversation
…the FDB Database created.
Contributor
Author
|
@brownleej expected syntax is the same for an optional argument:
|
Contributor
Author
apkar
reviewed
Mar 28, 2019
apkar
reviewed
Mar 28, 2019
Contributor
Author
|
@ajbeamon can you take a look at this? I briefly checked where the |
ajbeamon
reviewed
Apr 1, 2019
Contributor
ajbeamon
left a comment
ajbeamon
left a comment
There was a problem hiding this comment.
Yeah, I think this looks fine. I made a minor tweak to the wording of the option documentation that you can take if you want, but otherwise I approve.
Co-Authored-By: dongxinEric <jiangzian1987dx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…the FDB Database created.