Skip to content

Only support 6.3.20+ #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johscheuer merged 4 commits into from
Feb 11, 2022
Merged

Only support 6.3.20+ #1056

johscheuer merged 4 commits into from
Feb 11, 2022

Conversation

@johscheuer
Copy link
Member

@johscheuer johscheuer commented Feb 2, 2022

Description

Fixes: #743

Type of change

Please select one of the options below.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Discussion

I added the new compatibility to our docs. We might want to consider to remove some older 6.2 versions to reduce our if branching.

Testing

local.

Documentation

Added.

Follow-up

@johscheuer johscheuer requested a review from brownleej February 2, 2022 11:42
johscheuer
johscheuer commented Feb 2, 2022
View reviewed changes
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Feb 2, 2022

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-kubernetes-operator-pr
  • Commit ID: 10f3da6
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@johscheuer johscheuer changed the title Drop support for 6.1 Only support 6.3.20+ Feb 4, 2022
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Feb 4, 2022

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-kubernetes-operator-pr
  • Commit ID: e6bdc67
  • Result: FAILED
  • Error: Error while executing command: make -C tests -kj prOperator. Reason: exit status 2
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Feb 4, 2022

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-kubernetes-operator-pr
  • Commit ID: 958ce0e
  • Result: FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)

brownleej
brownleej requested changes Feb 8, 2022
View reviewed changes
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Feb 9, 2022

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-kubernetes-operator-pr
  • Commit ID: 524d45b
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

brownleej
brownleej approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@brownleej brownleej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johscheuer johscheuer merged commit c6fc0d9 into FoundationDB:main Feb 11, 2022
@johscheuer johscheuer deleted the remove-6-1 branch February 11, 2022 10:19
@johscheuer johscheuer mentioned this pull request Mar 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brownleej brownleej brownleej approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop support for 6.1

3 participants

@johscheuer @foundationdb-ci @brownleej