Check if processes are excluded before run exclude command in CanSafelyRemove #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AWS CodeBuild CI Report for Linux CentOS 7
|
Contributor
AWS CodeBuild CI Report for Linux CentOS 7
|
Contributor
AWS CodeBuild CI Report for Linux CentOS 7
|
09harsh
pushed a commit
to 09harsh/fdb-kubernetes-operator
that referenced
this pull request
Aug 1, 2022
…lyRemove (FoundationDB#1064) * Check if processes are excluded before run exclude command in CanSafelyRemove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for only checking with the
excludecommand for already excluded addresses if they are fully excluded and if they can be removed from the cluster. Before this change it could happen that we invoked theCanSafelyRemovemethod before an address was excluded in the exclude sub reconciler (which has some additional age checks). In order to be more restrictive and be safer I added a check to only run the exclude command for processes that are marked as excluded in the cluster status.Type of change
Discussion
Are there any design details that you would like to discuss further?
Testing
local testing and I will add some more unit tests.
Documentation
Follow-up
I will create a design doc for some ideas how to improve the exclusion handling in the operator.