Changes to support DNS name testing #1073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can bring back pods while the database is unreachable.
Contributor
AWS CodeBuild CI Report for Linux CentOS 7
|
johscheuer
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is addressed. If this change resolves an issue, please include the issue number in the description.
This includes some smaller changes that I made in the course of testing the new DNS name feature.
Type of change
Please select one of the options below.
Discussion
Are there any design details that you would like to discuss further?
No�.
Testing
Please describe the tests that you ran to verify your changes. Unit tests?
Manual testing?
I tested this in my local dev environment.
Do we need to perform additional testing once this is merged, or perform in a larger testing environment?
No.
Documentation
Did you update relevant documentation within this repository?
No.
Follow-up
Are there any follow-up issues that we should pursue in the future?
No.
Does this introduce new defaults that we should re-evaluate in the future?
No.