Remove the watch namespace flag from the sample deployment. #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltsampros
approved these changes
Mar 8, 2022
Contributor
AWS CodeBuild CI Report for Linux CentOS 7
|
johscheuer
approved these changes
Mar 9, 2022
Member
johscheuer
left a comment
johscheuer
left a comment
There was a problem hiding this comment.
Thanks for doing that 👍 Could you open an issue to add this flag once 1.0 is released? Otherwise we might forget about it.
Member
|
Issue for reference: #1095 |
09harsh
pushed a commit
to 09harsh/fdb-kubernetes-operator
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is addressed. If this change resolves an issue, please include the issue number in the description.
This removes a flag from our sample deployments that isn't supported in the last stable release. This flag doesn't have any effect in the context where it was being used, because it was being set to the environment variable that is used as the default when the flag is omitted.
Resolves #1081
Type of change
Please select one of the options below.
Discussion
Are there any design details that you would like to discuss further?
I considered changing the version of the operator in the deployment to use the latest tag, but we would want to revert that in the future, and I don't think we need this flag in the sample deployment.
Testing
Please describe the tests that you ran to verify your changes. Unit tests?
Manual testing?
I manually deployed the config in my local environment.
Do we need to perform additional testing once this is merged, or perform in a larger testing environment?
No.
Documentation
Did you update relevant documentation within this repository?
No.
Follow-up
Are there any follow-up issues that we should pursue in the future?
No.
Does this introduce new defaults that we should re-evaluate in the future?
No.