Implement Tuple Layer #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taking Go binding as reference
jzhou77
approved these changes
Oct 3, 2025
1amageek
added a commit
to 1amageek/fdb-swift-bindings
that referenced
this pull request
Nov 8, 2025
Convert SubspaceError from enum to struct-based error with error codes. This design follows SwiftNIO's FileSystemError pattern and provides better extensibility for future error cases. The struct-based approach will make it easier to add new error types when the Directory Layer is introduced in the next PR. Also replace guard with if in strinc error check for better readability, as guard is intended for early returns. Addresses: glbrntt review comments FoundationDB#3, FoundationDB#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've to add some tests to make sure the encoding stays consistent with other bindings. Integer encoding is the one that'll definitely need that.