Skip to content

Conversation

@vishesh
Copy link
Contributor

@vishesh vishesh commented Oct 8, 2025

No description provided.

@vishesh vishesh requested a review from jzhou77 October 8, 2025 20:57
@jzhou77 jzhou77 merged commit 538d923 into main Oct 8, 2025
1amageek added a commit to 1amageek/fdb-swift-bindings that referenced this pull request Nov 8, 2025
Convert SubspaceError from enum to struct-based error with error codes.
This design follows SwiftNIO's FileSystemError pattern and provides
better extensibility for future error cases.

The struct-based approach will make it easier to add new error types
when the Directory Layer is introduced in the next PR.

Also replace guard with if in strinc error check for better readability,
as guard is intended for early returns.

Addresses: glbrntt review comments FoundationDB#3, FoundationDB#5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants