Allow uppercase letters in package names#2718
Merged
Merged
Conversation
The /^[a-z0-9._-]+$/ pattern rejected theme and plugin package names containing uppercase letters (e.g. "MyTheme"), breaking previously-installed packages. Expanded to /^[a-zA-Z0-9._-]+$/ to match the broader naming convention used in the wild. https://claude.ai/code/session_01CeqkQ4HBGw1rYVtx83hcfB
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the package name validation regex to accept uppercase letters (A-Z) in addition to lowercase letters, allowing for more flexible package naming conventions.
Changes
VALID_PACKAGE_NAMEregex pattern from/^[a-z0-9._-]+$/to/^[a-zA-Z0-9._-]+$/inapp/src/package.tsapp/src/package.tsandapp/src/package-manager.tsto reflect the new validation patternDetails
This change relaxes the package naming constraints to permit camelCase and PascalCase naming conventions, which are common in JavaScript/TypeScript ecosystems. The validation now accepts:
Error messages have been updated to accurately reflect the new validation requirements.
https://claude.ai/code/session_01CeqkQ4HBGw1rYVtx83hcfB