The admin search view is no longer available. Use phoenix instead.#32
Merged
mbektimirov merged 1 commit intomasterfrom Feb 1, 2017
Merged
The admin search view is no longer available. Use phoenix instead.#32mbektimirov merged 1 commit intomasterfrom
mbektimirov merged 1 commit intomasterfrom
Conversation
The admin search view should not have been available to search orders. This was abused in the storefronts to create the my orders pages. There was a bug in isaac that let this happen and now it has been fixed. So this search view is no longer available to customer JWTs. Unfortunately this will return a different payload than the search view. This requires fixing the storefronts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The admin search view should not have been available to search orders.
This was abused in the storefronts to create the my orders pages.
There was a bug in isaac that let this happen and now it has been fixed.
So this search view is no longer available to customer JWTs.
Unfortunately this will return a different payload than the search view.
This requires fixing the storefronts.
Relavent PR FoxComm/highlander#787