Conversation
Checkout can now work in a non-browser setting.
anru
suggested changes
Feb 17, 2017
Contributor
anru
left a comment
anru
left a comment
There was a problem hiding this comment.
Also in order to get http://foxcomm.github.io/api-js/ updated you should run npm run docs and include modified index.html to PR
| function sphexTrackerUrl(tracker, saltFunction = randomSalt) { | ||
| const { channel, subject, verb, obj, objId, count } = tracker; | ||
|
|
||
| const realCount = _.isNil(count) ? 1 : count; |
Contributor
There was a problem hiding this comment.
Lets get rid of lodash dependency. We can test for null and undefined without whole of lodash library:
const { channel, subject, verb, obj, objId, count = 1 } = tracker;
anru
approved these changes
Feb 17, 2017
Contributor
|
looks good now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides changes to assist in tracking and user simulation.