Extend FilterGroup component with ability to be initially expanded.#14
Merged
Extend FilterGroup component with ability to be initially expanded.#14
Conversation
anru
suggested changes
Jun 19, 2017
|
|
||
| getExpandedState = () => { | ||
| return this.props.initialyExpanded ? !this.state.expanded : this.state.expanded; | ||
| } |
Contributor
There was a problem hiding this comment.
it looks weird. Why we should rely on initialyExpanded each time we render page ?
initially word has intent to set value only on initialization. like this:
state = {
expanded: this.props.initialyExpanded,
};
Contributor
Author
There was a problem hiding this comment.
@anru I knew that using props values to set initial state is 'anti-pattern', no?
Contributor
There was a problem hiding this comment.
No, it's totally ok If you know what are you doing. If you want to set up some initial value for state variable -- well, you are creator of a program.
Contributor
Author
There was a problem hiding this comment.
Sounds good, I was initially thinking of doing it the way you described, than remembered that its not encouraged.
I'll change that.
anru
approved these changes
Jun 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.