Reapply tap workaround for columns #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igr001-galactica
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235.
In #226 we removed a tap listener. As a result, JA4 fingerprints stopped appearing in Wireshark columns, even though they still show up in the Info pane and in tshark. This is due to how post-dissectors interact with Wireshark’s column population - columns may not be filled unless a tap drives the updates.
This PR reintroduces the tap-based workaround to ensure JA4 fields are again visible in columns. It’s a temporary fix and can be removed once Wireshark consistently supports column population from post-dissectors.