Changing CheckForUpdates to cope with larger mod lists#258
Open
Turner605 wants to merge 1 commit intoFoxlider:masterfrom
Open
Changing CheckForUpdates to cope with larger mod lists#258Turner605 wants to merge 1 commit intoFoxlider:masterfrom
Turner605 wants to merge 1 commit intoFoxlider:masterfrom
Conversation
Steam API throttling was occurring and not updating mods, made it async and added a small delay, takes a second to update larger lists, delay timer could maybe be adjusted but this worked on the initial test.
|
liamcannon
reviewed
Apr 23, 2026
| } | ||
|
|
||
| private void CheckForUpdates_Click(object sender, RoutedEventArgs e) | ||
| private async void CheckForUpdates_Click(object sender, RoutedEventArgs e) |
Contributor
There was a problem hiding this comment.
this should become an async Task if you're going to await the task instead of doing Task.Delay(300).Wait()
diaverso
added a commit
to diaverso/FASTER
that referenced
this pull request
May 4, 2026
Bugs fixed: - Foxlider#255 forcedDifficulty missing quotes in server.cfg - Foxlider#254 Deploy All destroys symlink targets (ReparsePoint check) - Foxlider#251/Foxlider#115 Performance tab not cloned (JsonIgnore on PerfPreset) - Foxlider#242 Mod status stuck as NotComplete after cancel - Foxlider#184/Foxlider#221 logObjectNotFound field naming + nameof refactor (81 calls) - Foxlider#167 Bad Steam API Key silently fails (user-visible error) - Foxlider#259 Async deadlock in RunModsUpdater (.Wait -> await + Unwrap) - Foxlider#238 NullRef in SteamLogin after nulling SteamClient - Foxlider#131 Deploy mods: pre-flight check + UnauthorizedAccessException msg PRs integrated: - Foxlider#239 Pipelines: add missing DOTNET_VERSION env var - Foxlider#252 MaxMsgSend clone fix (covered by Foxlider#251 fix) - Foxlider#258 Steam API throttling 300ms + async Task (fixes SonarQube C grade) - Foxlider#230 Configurable server language (11 options) - Foxlider#231 New launch args: hugePages, bePath, exThreads, loadMissionToMemory, limitFPS, enableSteamLogs - Foxlider#246 class AdvancedOptions {} block in server.cfg output - Foxlider#198 Purge & Reinstall All / per-mod buttons Features added: - Foxlider#241 -keysFolder launch parameter - Foxlider#217 AntiFlood class configurable in server.cfg - Foxlider#229 missionHTTPDownloadBaseURL in server.cfg - Foxlider#209 Purge Unused Mods button - Foxlider#216 Profile reordering with Up/Down buttons in sidebar Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
I was encountering issues with larger mod lists in which the client would not fetch down mod data. The Steam API was presumably throttling the requests as they were all being sent at once and therefore no mod data was being updated.
The Steam API does support a multi id information request but this solution was much faster to implement as a fix for now, it can be re-visited if needed at a later date. The delay timer could potentially be tweaked and lowered but this value worked on for me fine.
This issue has been raised in the discord a couple of times by different people.
How Has This Been Tested?
Release version built and used on my dedicated server, mod information fetched down fine no issues. The functionality itself has not changed therefore the unit changes do not need to be modified and all pass.
Types of changes
Checklist: