refactor: Optimize production for memory usage #453
Conversation
* Use dynamic import for schema based on environment * If production use pre-generated json to avoid loading vega generator -- big memory footprint reduction * If not production use vega so schema is always up to date
✅ Deploy Preview for multi-scrobbler ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📦 A new release has been made for this pull request.To play around with this PR, pull an image:
Images are available for x86_64 and ARM64.
|
|
The changes are effective, as mentioned in #348 . FYI: Typescript 5.9 introduces import defer, https://devblogs.microsoft.com/typescript/announcing-typescript-5-9/#support-for-import-defer |
This is a massive improvement over the current mainline image, which was using 400+MB of memory steadily. Thank you for the quick turnaround on the optimizations - obviously, my tests are not indepth but from what I can see, this is working as I expect. |
Hey that's pretty neat! It doesn't look like nodejs supports My plan for memory optimization after this is to try running ts on node natively which defer would not be supported in. Thanks everyone for the quick feedback on testing this. |
Checklist before requesting a review
Describe your changes
Issue number and link, if applicable