Credentials encoding differences between Environments#14
Merged
Conversation
Repository owner
deleted a comment from
Kasui92
Apr 10, 2025
Collaborator
|
@FraWolf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title says, I have implemented a different method to calculate and encode credentials for OAuth2 flow. On node.js environment will be used Buffer, and, in the browser-client, will be used btoa() built-in method.
This pull request includes several changes to the codebase, primarily focusing on updating contributor information, adding a new utility function, and modifying the OAuth class to check the running environment. Below are the most important changes:
Contributor Information Update:
package.json: Updated the email addresses and URLs for contributors Francesco Lombardo and Luca Pattocchio.Utility Function Addition:
src/adapters/utils.ts: Added a new functioncheckRunningEnvironmentto determine if the code is running in a Node.js environment or a browser environment.OAuth Class Enhancements:
src/contents/oauth/index.ts: Imported the newcheckRunningEnvironmentfunction and added a privateenvironmentgetter in theOAuthclass to utilize this function.src/contents/oauth/index.ts: Modified thebtoamethod in theOAuthclass to useBufferfor base64 encoding in a Node.js environment andbtoain a browser environment.