Merged
Conversation
This reverts commit 4d6e3ec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The biggest nuisance in FrameOS has always been the long compilation time. Every small change in the scene, every updated config that you forgot to promote to a state node, everything takes a 2-5min round trip to see in effect.
Let's cut that short. Compilation is great for scenes that really need to be fast, but if the render takes 20 seconds, it doesn't matter if the scene itself renders in 0.1 or 0.01 seconds. So let's optimize for usability.
This PR implements a scene.json interpreter. Here's a full deploy for a new interpreted scene:
Now, I had to remove support for nim code nodes, as we just can't evaluate that in the interpreter. Instead I integrated QuickJS. Now all ad-hoc code nodes can be written with plain old javascript:
To set a scene as "interpreted", update the options here:
This will most likely become the new default as soon as it's stable.
There are still some TODOs before this can be merged: