[PLATFORM-543] Refactor Rolodex.Schema.field/3 macro #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than define a bunch of `__field__/1` functions on the caller module as the `field/3` macro is invoked, we only collect field definition metadata in an accumulator attribute. Later, we serialize the field definitions together into a formatted map on demand via `__schema__(:fields)`. This change will allow users to define fields on their schemas in for comprehensions or maps, without any compiler warnings about unmatchable function heads.
sjkaliski
approved these changes
May 6, 2019
bceskavich
added a commit
that referenced
this pull request
May 6, 2019
Rather than define a bunch of `__field__/1` functions on the caller module as the `field/3` macro is invoked, we only collect field definition metadata in an accumulator attribute. Later, we serialize the field definitions together into a formatted map on demand via `__schema__(:fields)`. This change will allow users to define fields on their schemas in for comprehensions or maps, without any compiler warnings about unmatchable function heads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than define a bunch of
__field__/1functions on the callermodule as the
field/3macro is invoked, we only collect fielddefinition metadata in an accumulator attribute. Later, we serialize
the field definitions together into a formatted map on demand via
__schema__(:fields).This change will allow users to define fields on their schemas in
for comprehensions or maps, without any compiler warnings about
unmatchable function heads.