-
Notifications
You must be signed in to change notification settings - Fork 10
Labels
bugSomething isn't workingSomething isn't working
Description
Phlex v0.1.0 includes an optional dependency on NumPy. If the intention is to use NumPy to translate between (e.g.) C++ std::vector<T> types and Python types, then NumPy should be a required dependency.
Unfortunately, our CI system does not currently build (or test) with NumPy. This is evidenced by the lack of py:vec test in the PR that incorporated Python support.
An attempt to mandate NumPy using CMake is shown in PR #219. The failure to import NumPy is explicit when running the tests. Specifically:
52/61 Test #54: py:vec ..................................***Failed 0.16 sec
Using configuration file: /__w/phlex/phlex/phlex-src/test/python/pyvec.jsonnet
[2026-01-07 19:03:44.324] [info] Number of worker threads: 4
ModuleNotFoundError: No module named 'numpy'
ImportError: numpy._core.multiarray failed to import
[2026-01-07 19:03:44.409] [debug] Routed 0 messages in 0 microseconds (-nan microseconds per message)
[2026-01-07 19:03:44.409] [info]
[2026-01-07 19:03:44.409] [info] CPU time: 0.06370s Real time: 0.08574s CPU efficiency: 74.30%
[2026-01-07 19:03:44.409] [info] Max. RSS: 30.628 MB
build with numpy support, but numpy not importable
We should mandate the use of NumPy and solve this problem.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working