Fix(actions): Make detect-relevant-changes robust to missing SHAs#138
Merged
greenc-FNAL merged 1 commit intomainfrom Dec 1, 2025
Merged
Fix(actions): Make detect-relevant-changes robust to missing SHAs#138greenc-FNAL merged 1 commit intomainfrom
greenc-FNAL merged 1 commit intomainfrom
Conversation
The detect-relevant-changes reusable action would previously fail if the base or head SHA was missing from the repository, for example, due to a force-push. This change adds a check to verify that both SHAs exist before running 'git diff'. If either SHA is not found, the action now logs a warning and outputs matched=true instead of erroring out.
knoepfel
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The detect-relevant-changes reusable action would previously fail if the base or head SHA was missing from the repository, for example, due to a force-push.
This change adds a check to verify that both SHAs exist before running 'git diff'. If either SHA is not found, the action now logs a warning and outputs matched=true instead of erroring out.