Implement Trigger-Specific Build Matrix Defaults#143
Merged
greenc-FNAL merged 3 commits intoFramework-R-D:mainfrom Dec 2, 2025
Merged
Implement Trigger-Specific Build Matrix Defaults#143greenc-FNAL merged 3 commits intoFramework-R-D:mainfrom
greenc-FNAL merged 3 commits intoFramework-R-D:mainfrom
Conversation
Contributor
greenc-FNAL
commented
Dec 2, 2025
greenc-FNAL
commented
- feat: implement trigger-specific build matrix defaults
- Committing Python linting fixes
- fix: address ruff and mypy issues
The `generate-build-matrix` action now uses intelligent, trigger-specific defaults for build configurations. - Workflows triggered by `push`, `pull_request`, and `pull_request_target` now default to a minimal `gcc/none` configuration. - Workflows triggered by an `issue_comment` default to `gcc/none` and `clang/none`. - Manual `workflow_dispatch` triggers default to running all available build combinations. The user input handling has also been improved to follow a clear precedence: 1. An explicit list of builds (e.g., `gcc/asan`) overrides all defaults. 2. A modified list (e.g., `+gcc/tsan`, `all -clang/none`) alters the trigger-specific default set. 3. No input uses the trigger-specific default directly.
This commit addresses the Python linting and type-checking issues reported by `ruff` and `mypy`. - Added module and function docstrings. - Corrected import order. - Removed an unnecessary `list()` call.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #143 +/- ##
==========================================
+ Coverage 80.31% 81.14% +0.83%
==========================================
Files 115 116 +1
Lines 1910 2042 +132
Branches 302 326 +24
==========================================
+ Hits 1534 1657 +123
- Misses 247 250 +3
- Partials 129 135 +6
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Note: Errors reported in https://github.com/Framework-R-D/phlex/actions/runs/19872176341/job/56950540477?pr=143 are in Python files that were not touched by this PR, and will addressed in a subsequent PR. |
knoepfel
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.