Make unfold interface reflect design document#161
Merged
greenc-FNAL merged 2 commits intoFramework-R-D:mainfrom Dec 4, 2025
Merged
Make unfold interface reflect design document#161greenc-FNAL merged 2 commits intoFramework-R-D:mainfrom
greenc-FNAL merged 2 commits intoFramework-R-D:mainfrom
Conversation
Member
|
@phlexbot format |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 81.14% 81.16% +0.02%
==========================================
Files 116 115 -1
Lines 2042 2039 -3
Branches 326 328 +2
==========================================
- Hits 1657 1655 -2
Misses 250 250
+ Partials 135 134 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
c986a2f to
197aa5a
Compare
Contributor
Author
|
@phlexbot format |
Contributor
Author
|
Note that the code coverage dropped because I deleted code that I presume had coverage. I didn't add any new code to glue.hpp. |
Member
Correct. |
knoepfel
approved these changes
Dec 4, 2025
greenc-FNAL
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make unfold interface reflect design document. Name should be the first argument of the unfold function.
See Issue #90