Skip to content

Make unfold interface reflect design document#161

Merged
greenc-FNAL merged 2 commits intoFramework-R-D:mainfrom
wddgit:unfoldInterface
Dec 4, 2025
Merged

Make unfold interface reflect design document#161
greenc-FNAL merged 2 commits intoFramework-R-D:mainfrom
wddgit:unfoldInterface

Conversation

@wddgit
Copy link
Copy Markdown
Contributor

@wddgit wddgit commented Dec 4, 2025

Make unfold interface reflect design document. Name should be the first argument of the unfold function.

See Issue #90

@knoepfel
Copy link
Copy Markdown
Member

knoepfel commented Dec 4, 2025

@phlexbot format

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   81.14%   81.16%   +0.02%     
==========================================
  Files         116      115       -1     
  Lines        2042     2039       -3     
  Branches      326      328       +2     
==========================================
- Hits         1657     1655       -2     
  Misses        250      250              
+ Partials      135      134       -1     
Flag Coverage Δ
unittests 81.16% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/core/framework_graph.hpp 100.00% <100.00%> (ø)
phlex/core/glue.hpp 98.11% <ø> (-0.17%) ⬇️
phlex/core/graph_proxy.hpp 88.88% <ø> (ø)

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe26288...113b584. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wddgit
Copy link
Copy Markdown
Contributor Author

wddgit commented Dec 4, 2025

@phlexbot format

@wddgit
Copy link
Copy Markdown
Contributor Author

wddgit commented Dec 4, 2025

Note that the code coverage dropped because I deleted code that I presume had coverage. I didn't add any new code to glue.hpp.

@knoepfel
Copy link
Copy Markdown
Member

knoepfel commented Dec 4, 2025

Note that the code coverage dropped because I deleted code that I presume had coverage. I didn't add any new code to glue.hpp.

Correct.

@knoepfel knoepfel requested a review from greenc-FNAL December 4, 2025 19:44
@greenc-FNAL greenc-FNAL merged commit 70a3bba into Framework-R-D:main Dec 4, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants