Skip to content

Switch to dynamic_cast instead of string comparison for product retrieval#203

Merged
knoepfel merged 1 commit intoFramework-R-D:mainfrom
knoepfel:switch-to-dynamic-cast
Jan 9, 2026
Merged

Switch to dynamic_cast instead of string comparison for product retrieval#203
knoepfel merged 1 commit intoFramework-R-D:mainfrom
knoepfel:switch-to-dynamic-cast

Conversation

@knoepfel
Copy link
Member

Dynamic casts were originally avoided when retrieving data products due to various RTTI difficulties across plugins. This PR restores them.

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (76.58%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   76.61%   76.58%   -0.04%     
==========================================
  Files         124      124              
  Lines        2733     2733              
  Branches      475      475              
==========================================
- Hits         2094     2093       -1     
  Misses        446      446              
- Partials      193      194       +1     
Flag Coverage Δ
unittests 76.58% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/model/products.hpp 95.00% <100.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c7635...dc46c5c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel force-pushed the switch-to-dynamic-cast branch from 51075f5 to dc46c5c Compare December 22, 2025 20:43
Copy link
Contributor

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Although it is unclear what changed between the time it did not work and now).

@knoepfel
Copy link
Member Author

knoepfel commented Jan 9, 2026

LGTM. (Although it is unclear what changed between the time it did not work and now).

The last time I ran into the dynamic_cast problem was with older versions of apple-clang and GCC. I'm hopeful we're using new enough versions that the RTTI is consistent across dynamically loaded libraries. It seems to be consistent enough in the CI, at least (and on my Mac).

@knoepfel knoepfel merged commit 8890195 into Framework-R-D:main Jan 9, 2026
35 of 36 checks passed
@knoepfel knoepfel deleted the switch-to-dynamic-cast branch January 9, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants