Switch to dynamic_cast instead of string comparison for product retrieval#203
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (76.58%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #203 +/- ##
==========================================
- Coverage 76.61% 76.58% -0.04%
==========================================
Files 124 124
Lines 2733 2733
Branches 475 475
==========================================
- Hits 2094 2093 -1
Misses 446 446
- Partials 193 194 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
51075f5 to
dc46c5c
Compare
pcanal
left a comment
There was a problem hiding this comment.
LGTM. (Although it is unclear what changed between the time it did not work and now).
The last time I ran into the |
Dynamic casts were originally avoided when retrieving data products due to various RTTI difficulties across plugins. This PR restores them.