Skip to content

Install one more header file#217

Merged
knoepfel merged 1 commit intoFramework-R-D:mainfrom
knoepfel:one-more-header
Dec 19, 2025
Merged

Install one more header file#217
knoepfel merged 1 commit intoFramework-R-D:mainfrom
knoepfel:one-more-header

Conversation

@knoepfel
Copy link
Copy Markdown
Member

The phlex/detail/plugin_macros.hpp header was omitted from installation whenever it was first introduced in commit 71457e0.

@knoepfel knoepfel requested a review from greenc-FNAL December 19, 2025 20:22
Copy link
Copy Markdown
Contributor

@greenc-FNAL greenc-FNAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (76.71%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   76.31%   76.71%   +0.40%     
==========================================
  Files         124      124              
  Lines        2748     2748              
  Branches      476      476              
==========================================
+ Hits         2097     2108      +11     
+ Misses        454      448       -6     
+ Partials      197      192       -5     
Flag Coverage Δ
unittests 76.71% <ø> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5392a32...412e7c9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel merged commit dcfe491 into Framework-R-D:main Dec 19, 2025
35 of 36 checks passed
@knoepfel knoepfel deleted the one-more-header branch December 19, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants