Clarify SPACK_GID usage is correct in devcontainer Dockerfile
#231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed review feedback questioning the use of numeric GID in
usermod -aG $SPACK_GIDcommand.Resolution
No code changes required. The current implementation is correct:
usermod -aGaccepts either group names or numeric GIDs per its man pagespackgroup with GID 2000usermod -aG 2000 vscodecorrectly adds user to the spack group by numeric IDThe variable naming (
SPACK_GID) accurately reflects its usage as a numeric group identifier, which is a valid approach for theusermodcommand.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.