Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 7, 2026

Addressed review feedback questioning the use of numeric GID in usermod -aG $SPACK_GID command.

Resolution

No code changes required. The current implementation is correct:

  • usermod -aG accepts either group names or numeric GIDs per its man page
  • Base image creates spack group with GID 2000
  • usermod -aG 2000 vscode correctly adds user to the spack group by numeric ID

The variable naming (SPACK_GID) accurately reflects its usage as a numeric group identifier, which is a valid approach for the usermod command.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Fix SPACK_GID usage in VSCode dev container setup Clarify SPACK_GID usage is correct in devcontainer Dockerfile Jan 7, 2026
Copilot AI requested a review from greenc-FNAL January 7, 2026 19:56
@greenc-FNAL greenc-FNAL marked this pull request as ready for review January 7, 2026 19:56
Copilot AI review requested due to automatic review settings January 7, 2026 19:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@greenc-FNAL greenc-FNAL merged commit da7ab69 into feature/vscode-dev-container Jan 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants