Skip to content

Quote $GITHUB_OUTPUT where used #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knoepfel merged 1 commit into from
Jan 30, 2026
Merged

Quote $GITHUB_OUTPUT where used #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/detect-act-env/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ runs:
ACTOR: ${{ github.actor }}
run: |
if [ "$ACTOR" = "nektos/act" ] || [ "${ACT:-}" = "true" ] || [ "${ACT:-}" = "1" ]; then
echo "is_act=true" >> $GITHUB_OUTPUT
echo "is_act=true" >> "$GITHUB_OUTPUT"
else
echo "is_act=false" >> $GITHUB_OUTPUT
echo "is_act=false" >> "$GITHUB_OUTPUT"
fi
10 changes: 5 additions & 5 deletions .github/actions/handle-fix-commit/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ runs:
working-directory: ${{ inputs.working-directory }}
run: |
if [[ -n $(git status --porcelain) ]]; then
echo "changes=true" >> $GITHUB_OUTPUT
echo "changes=true" >> "$GITHUB_OUTPUT"
else
echo "changes=false" >> $GITHUB_OUTPUT
echo "changes=false" >> "$GITHUB_OUTPUT"
fi

- name: No changes to apply
Expand Down Expand Up @@ -76,8 +76,8 @@ runs:
if git push origin HEAD:${{ inputs.pr-info-ref }}; then
echo "Push successful on attempt $i."
COMMIT_SHA=$(git rev-parse HEAD)
echo "commit_sha=$COMMIT_SHA" >> $GITHUB_OUTPUT
echo "pushed=true" >> $GITHUB_OUTPUT
echo "commit_sha=$COMMIT_SHA" >> "$GITHUB_OUTPUT"
echo "pushed=true" >> "$GITHUB_OUTPUT"
exit 0
fi
if [ $i -eq ${{ inputs.retry-attempts }} ]; then
Expand Down Expand Up @@ -110,7 +110,7 @@ runs:
working-directory: ${{ inputs.working-directory }}
run: |
git diff > fix.patch
echo "patch_name=fix.patch" >> $GITHUB_OUTPUT
echo "patch_name=fix.patch" >> "$GITHUB_OUTPUT"

- name: Upload patch
if: steps.create_patch.outputs.patch_name
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/setup-build-env/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ runs:
mkdir -p "$GITHUB_WORKSPACE/$BUILD_PATH"

# Set outputs
printf 'source-dir=%s/%s\n' "$GITHUB_WORKSPACE" "$SOURCE_PATH" >> $GITHUB_OUTPUT
printf 'build-dir=%s/%s\n' "$GITHUB_WORKSPACE" "$BUILD_PATH" >> $GITHUB_OUTPUT
printf 'source-dir=%s/%s\n' "$GITHUB_WORKSPACE" "$SOURCE_PATH" >> "$GITHUB_OUTPUT"
printf 'build-dir=%s/%s\n' "$GITHUB_WORKSPACE" "$BUILD_PATH" >> "$GITHUB_OUTPUT"

echo "Source directory: $GITHUB_WORKSPACE/$SOURCE_PATH"
echo "Build directory: $GITHUB_WORKSPACE/$BUILD_PATH"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cmake-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ jobs:

- name: Extract repository name
id: repo_name
run: echo "name=$(echo '${{ needs.pre-check.outputs.repo }}' | sed 's:.*/::')" >> $GITHUB_OUTPUT
run: echo "name=$(echo '${{ needs.pre-check.outputs.repo }}' | sed 's:.*/::')" >> "$GITHUB_OUTPUT"

- name: Configure CMake
id: configure
Expand Down
Loading