Skip to content

Restore integer representation of nproc value#283

Merged
knoepfel merged 1 commit intoFramework-R-D:mainfrom
knoepfel:fix-cmake-configure
Feb 3, 2026
Merged

Restore integer representation of nproc value#283
knoepfel merged 1 commit intoFramework-R-D:mainfrom
knoepfel:fix-cmake-configure

Conversation

@knoepfel
Copy link
Copy Markdown
Member

@knoepfel knoepfel commented Feb 3, 2026

Also trims newline from the returned value of nproc (or its equivalent)

This PR addresses the failure:

43: Error retrieving parameter 'expected_parallelism':                                                                              
43: not a number [boost.json:26 at /Users/kyleknoepfel/work/phlex-devel/local/.spack-env/._view/dlpaqk7urgh5dyallqyurp23btjxmoxo/include/boost/json/value.hpp:2370:30 in function 'typename std::enable_if<std::is_arithmetic<T>::value && !std::is_same<T, bool>::value
, T>::type boost::json::value::to_number(system::error_code &) const [T = unsigned long]']

Also trims newline from the returned value of nproc (or its equivalent)
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (75.24%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   75.20%   75.24%   +0.03%     
==========================================
  Files         124      124              
  Lines        2916     2916              
  Branches      513      513              
==========================================
+ Hits         2193     2194       +1     
  Misses        503      503              
+ Partials      220      219       -1     
Flag Coverage Δ
unittests 75.24% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35626f2...1fafbf8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@wlav wlav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Edit: I'll add that I also tried the commands and they work. :)

@knoepfel knoepfel merged commit 8fe4a39 into Framework-R-D:main Feb 3, 2026
43 of 44 checks passed
@knoepfel knoepfel deleted the fix-cmake-configure branch February 3, 2026 19:01
@knoepfel
Copy link
Copy Markdown
Member Author

knoepfel commented Feb 3, 2026

lgtm.

Edit: I'll add that I also tried the commands and they work. :)

Thanks @wlav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants