Homogenize "count" interface#287
Merged
knoepfel merged 3 commits intoFramework-R-D:mainfrom Feb 6, 2026
Merged
Conversation
knoepfel
force-pushed
the
unify-count-interface
branch
from
5c99721 to
20489af
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (74.36%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #287 +/- ##
==========================================
+ Coverage 74.28% 74.36% +0.08%
==========================================
Files 124 124
Lines 2955 2961 +6
Branches 513 516 +3
==========================================
+ Hits 2195 2202 +7
+ Misses 540 537 -3
- Partials 220 222 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
knoepfel
force-pushed
the
unify-count-interface
branch
2 times, most recently
from
612fa50 to
4ed9175
Compare
greenc-FNAL
previously requested changes
Feb 5, 2026
Includes more robust test for triggering exception in workflow
knoepfel
force-pushed
the
unify-count-interface
branch
from
4ed9175 to
d8c65d5
Compare
greenc-FNAL
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various tests check execution counts and data-cell counts against expected values. This PR homogenizes the interface a little. In addition:
test/framework_graph.cppthat tests the triggering of an exception (the previous check was comparing the number of the layer generator's emitted data cells to an expected thread count, which is very fragile)./job/run/subrun) when checking for the execution count of a given algorithm. This change is consistent with other uses of layer path in the repository.