Self-generated Amazon Q context/instructions#345
Conversation
greenc-FNAL
requested review from
Copilot,
knoepfel,
marcpaterno and
sabasehrish
There was a problem hiding this comment.
Pull request overview
Adds an Amazon Q “memory bank” under .amazonq/rules/memory-bank/ to document the repository’s product overview, tech stack, project structure, and development guidelines for tool-assisted context.
Changes:
- Add technology stack summary (languages, build system, dependencies, coverage, CI/CD).
- Add repository structure overview (major directories and architectural patterns).
- Add development/naming/testing guidelines and a short product overview.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
.amazonq/rules/memory-bank/tech.md |
Documents tech stack, build system, dependencies, and tooling |
.amazonq/rules/memory-bank/structure.md |
Documents directory layout and high-level architecture patterns |
.amazonq/rules/memory-bank/product.md |
Provides product/value proposition overview and links |
.amazonq/rules/memory-bank/guidelines.md |
Captures formatting, coding, testing, and workflow guidelines |
|
@phlexbot markdown-fix |
1 similar comment
|
@phlexbot markdown-fix |
|
Automatic markdownlint fixes pushed (commit 7da08fc). |
greenc-FNAL
force-pushed
the
maintenance/amazon-q-context
branch
from
7da08fc to
7b39772
Compare
|
@phlexbot markdown-fix |
|
Automatic markdownlint fixes pushed (commit ca8aa9d). |
knoepfel
left a comment
knoepfel
left a comment
There was a problem hiding this comment.
Thanks, @greenc-FNAL, for the PR. Several comments below. I understand these instructions are AI-generated, but not all of them are correct. Also, it looks like some files not directly related to this PR leaked in.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #345 +/- ##
==========================================
+ Coverage 82.26% 82.30% +0.03%
==========================================
Files 127 127
Lines 3102 3102
Branches 547 547
==========================================
+ Hits 2552 2553 +1
Misses 333 333
+ Partials 217 216 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Update actions/setup-node to v6.2.0 (hash 6044e13b5dc448c55e2357c09f80417699197238) in markdown-fix workflow per official releases - Replace thollander/actions-comment-pull-request with local Framework-R-D/phlex/.github/actions/pr-comment@main for consistency - Fix MD036 markdown lint errors in tech.md by converting bold emphasis to proper headings for tool names
Add prominent section emphasizing that: 1. Check LATEST version from official releases first 2. Then verify hash for that latest version 3. Never rely on potentially outdated training data
Co-authored-by: Kyle Knoepfel <knoepfel@fnal.gov>
- Remove leaked files (TEST_FIXES.md, TEST_CONVERSION_SUMMARY.md, etc.) - Correct C++ standard to C++23 in tech.md - Move PHLEX_PLUGIN_PATH to test-time environment variables - Use CMake preset for coverage workflow instead of explicit build type - Clarify cppyy is optional; Python plugin uses C API primarily - Change 'Root level' to 'Top-level' to avoid confusion with ROOT - Restore schedule trigger to cmake-build workflow
- `tech.md`:
- Correct the C++ standard specification to 23 in the C++ section.
- Remove the version information at the bottom as it is too prone to
drop out of sync.
greenc-FNAL
force-pushed
the
maintenance/amazon-q-context
branch
from
2353e62 to
35a5a21
Compare
No description provided.