Conversation
read a data product from disk with a type that doesn't match the type on disk.
Association. This models a physics algorithm in phlex writing two data products through FORM.
aolivier23
requested review from
barnaliy,
gemmeren,
greenc-FNAL and
wwuoneway
|
@phlexbot format |
|
No automatic jsonnetfmt fixes were necessary. |
|
No automatic markdownlint fixes were necessary. |
|
No automatic cmake-format fixes were necessary. |
|
Automatic clang-format fixes pushed (commit 4d27dc1). |
|
@phlexbot format |
|
No automatic cmake-format fixes were necessary. |
|
No automatic jsonnetfmt fixes were necessary. |
|
Automatic clang-format fixes pushed (commit 0388f10). |
|
No automatic markdownlint fixes were necessary. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #354 +/- ##
==========================================
+ Coverage 85.36% 86.55% +1.19%
==========================================
Files 122 122
Lines 2433 2433
Branches 389 389
==========================================
+ Hits 2077 2106 +29
+ Misses 233 208 -25
+ Partials 123 119 -4
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
dangling pointers. Thanks for catching that, Barnaliy!
…com/Framework-R-D/phlex into feature/aolivier-form-storage-tests
|
Thanks, @aolivier23, for all your work. |
propagates automatically: the root_storage library itself. This eliminates a duplicated USE_ROOT_STORAGE flag in test/form/CMakeLists.txt.
wwuoneway
left a comment
wwuoneway
left a comment
There was a problem hiding this comment.
thanks, the changes look fine.
gemmeren
left a comment
gemmeren
left a comment
There was a problem hiding this comment.
Looks good, you may want to adjust the #include guards.
gemmeren
left a comment
gemmeren
left a comment
There was a problem hiding this comment.
Removing asserts is fine by me. Thanks Andrew, Barnali
|
Although I’ve approved the PR, I noticed that the Code Coverage check is currently failing. I’m sure this will be taken care of shortly. |
Thanks Barnali, Kyle and I are taking a look at the test failure. We think it's unrelated to FORM. I will make sure tests pass before this merges. |
6 participants
Add more unit tests for FORM. This battery of unit tests focuses on the storage layer of FORM. These tests are only applied to the TBranch/TTree family of containers for now, but they are designed to eventually be applied to other technology choices.