Skip to content

Conversation

@knoepfel
Copy link
Member

@knoepfel knoepfel commented Sep 17, 2025

Using Boost's PFR library, it's possible to retrieve a particular field from a struct based on the provided type.

@knoepfel knoepfel requested a review from wddgit September 17, 2025 13:17
Copy link
Contributor

@wddgit wddgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question (not a suggestion one way or the other). Do you intend to remove the aliases like declared_predicates everywhere eventually?

Otherwise this looks good. It does bring in a dependence on boost PFR. I tried copilot on the PR and it helped me understand the PR quicker. It was able to explain what PFR was as I had never heard of it before.

@knoepfel
Copy link
Member Author

Thanks for the review, @wddgit.

Do you intend to remove the aliases like declared_predicates everywhere eventually?

Yes, I'd like to remove those aliases eventually. I have some commits that I'm trying to package as small PRs before submitting the larger registration-API PR. This is one of those commits. I hope the aliases will eventually go away.

It does bring in a dependence on boost PFR. I tried copilot on the PR and it helped me understand the PR quicker. It was able to explain what PFR was as I had never heard of it before.

I stumbled on PFR by accident—I was looking for something else in Boost and clicked on the PFR library link to learn more. Eventually, I would like to get rid of the use of PFR, but that requires some refactoring that I'm not quite ready to do yet.

@knoepfel knoepfel merged commit 411111a into Framework-R-D:main Sep 17, 2025
2 checks passed
@knoepfel knoepfel deleted the boost-pfr branch September 17, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants