fix: artifact download nested path and missing issues: write permission#419
Merged
greenc-FNAL merged 2 commits intojules-maintenance-fix-pr-comment-reactions-18132869807280577001from Mar 12, 2026
Conversation
Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [18132869807280577001] Fix clang-tidy-fix comment reactions and consolidate
fix: artifact download nested path and missing Mar 12, 2026
issues: write permission
greenc-FNAL
requested review from
aolivier23,
knoepfel,
marcpaterno and
sabasehrish
as code owners
greenc-FNAL
merged commit fdbc63b
into
jules-maintenance-fix-pr-comment-reactions-18132869807280577001
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes two CI workflow/action issues in the consolidated automation tooling: corrects where downloaded clang-tidy artifacts land to avoid silent “missing file” behavior, and grants the required token permission for updating reactions on issue comments.
Changes:
- Remove
actions/download-artifactpathoverride inpost-clang-tidy-resultsto prevent${build_path}/${build_path}/...nested extraction. - Add
issues: writetoformat-all.yamlsocomplete-pr-commentcan update reactions via the Issues/Comments Reactions API.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/format-all.yaml |
Adds issues: write permission required for reaction updates on issue comments. |
.github/actions/post-clang-tidy-results/action.yaml |
Downloads artifacts to workspace root so archived ${build_path}/... paths resolve correctly without duplication. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unresolved issues in the consolidated workflow/action infrastructure:
post-clang-tidy-resultsnested artifact path:download-artifactwithpath: ${{ inputs.build-path }}caused artifacts (uploaded as${build_path}/clang-tidy-fixes.yaml) to extract to${build_path}/${build_path}/clang-tidy-fixes.yaml, silently missing the existence check. Removed the explicitpathto download to workspace root, where${build_path}/clang-tidy-fixes.yamlresolves correctly.format-all.yamlmissingissues: write:complete-pr-commentuses the Reactions API on issue comments, which requiresissues: write. Without it, reaction updates were silently no-ops underGITHUB_TOKEN.📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.