Skip to content

Ensure correctness in query without suffix#429

Merged
greenc-FNAL merged 4 commits intoFramework-R-D:mainfrom
beojan:creator-query-correctness
Mar 17, 2026
Merged

Ensure correctness in query without suffix#429
greenc-FNAL merged 4 commits intoFramework-R-D:mainfrom
beojan:creator-query-correctness

Conversation

@beojan
Copy link
Contributor

@beojan beojan commented Mar 16, 2026

With this PR product_queries without a suffix are resolved correctly (though not necessarily efficiently just yet).

Fixes #108.

@greenc-FNAL
Copy link
Contributor

Review the full CodeQL report for details.

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   84.05%   84.24%   +0.18%     
==========================================
  Files         127      127              
  Lines        3306     3314       +8     
  Branches      562      564       +2     
==========================================
+ Hits         2779     2792      +13     
+ Misses        329      326       -3     
+ Partials      198      196       -2     
Flag Coverage Δ
unittests 84.24% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/core/edge_creation_policy.cpp 89.58% <100.00%> (+7.08%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4374590...ebfac03. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beojan
Copy link
Contributor Author

beojan commented Mar 16, 2026

@phlexbot format

@github-actions
Copy link
Contributor

Format Fixes Applied

✅ clang-format fixes pushed (commit ff061c3)
✅ ruff fixes pushed (commit 3177073)
✅ YAML formatter fixes pushed (commit 4432d42)

⚠️ Note: Some issues may require manual review.

@beojan beojan force-pushed the creator-query-correctness branch from 4432d42 to 5554ed0 Compare March 16, 2026 17:34
@beojan
Copy link
Contributor Author

beojan commented Mar 16, 2026

@phlexbot format

@github-actions
Copy link
Contributor

Format Fixes Applied

✅ clang-format fixes pushed (commit e9b2e90)

⚠️ Note: Some issues may require manual review.

@beojan beojan added this to the Prototype 0.2 milestone Mar 16, 2026
@greenc-FNAL greenc-FNAL force-pushed the creator-query-correctness branch from e9b2e90 to 199609a Compare March 16, 2026 19:19
@greenc-FNAL
Copy link
Contributor

Rebased against main to trigger fixed clang-tidy check.

Copy link
Contributor

@greenc-FNAL greenc-FNAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question: are the debug level log entries all appropriate for the completed PR, or are some of them useful during development only?

@beojan
Copy link
Contributor Author

beojan commented Mar 16, 2026

General question: are the debug level log entries all appropriate for the completed PR, or are some of them useful during development only?

They're useful any time you want to figure out why products didn't get wired up the way you intended.

@greenc-FNAL greenc-FNAL merged commit e0f0e92 into Framework-R-D:main Mar 17, 2026
38 checks passed
@beojan beojan deleted the creator-query-correctness branch March 17, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust product specification to allow creator names

2 participants