Ensure correctness in query without suffix#429
Ensure correctness in query without suffix#429greenc-FNAL merged 4 commits intoFramework-R-D:mainfrom
Conversation
|
Review the full CodeQL report for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #429 +/- ##
==========================================
+ Coverage 84.05% 84.24% +0.18%
==========================================
Files 127 127
Lines 3306 3314 +8
Branches 562 564 +2
==========================================
+ Hits 2779 2792 +13
+ Misses 329 326 -3
+ Partials 198 196 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@phlexbot format |
4432d42 to
5554ed0
Compare
|
@phlexbot format |
Format Fixes Applied✅ clang-format fixes pushed (commit e9b2e90) |
e9b2e90 to
199609a
Compare
|
Rebased against |
greenc-FNAL
left a comment
There was a problem hiding this comment.
General question: are the debug level log entries all appropriate for the completed PR, or are some of them useful during development only?
They're useful any time you want to figure out why products didn't get wired up the way you intended. |
With this PR product_queries without a suffix are resolved correctly (though not necessarily efficiently just yet).
Fixes #108.