Add header-guard check to pre-commit; update versions#439
Merged
knoepfel merged 2 commits intoFramework-R-D:mainfrom Mar 23, 2026
Merged
Add header-guard check to pre-commit; update versions#439knoepfel merged 2 commits intoFramework-R-D:mainfrom
knoepfel merged 2 commits intoFramework-R-D:mainfrom
Conversation
knoepfel
requested review from
aolivier23,
greenc-FNAL,
marcpaterno and
sabasehrish
as code owners
Contributor
|
Review the full CodeQL report for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #439 +/- ##
==========================================
+ Coverage 84.94% 85.12% +0.17%
==========================================
Files 127 127
Lines 3341 3341
Branches 574 574
==========================================
+ Hits 2838 2844 +6
+ Misses 306 305 -1
+ Partials 197 192 -5
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
greenc-FNAL
reviewed
Mar 23, 2026
Contributor
greenc-FNAL
left a comment
greenc-FNAL
left a comment
There was a problem hiding this comment.
The meat of the PR is uncontroversial, but there are some extraneous format changes to unrelated files that are doin' me a concern.
greenc-FNAL
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also applies changes to the code base using
pre-commit run -a.