clang-tidy: resolve bugprone-throwing-static-initialization

[greenc-FNAL]

Namespace-scope statics with non-trivial constructors (e.g. std::string, std::unordered_map) trigger bugprone-throwing-static-initialization because their constructors can throw before main(). The fix moves all such statics to function-local scope (guaranteed-lazy, exception-safe initialization).

Changes

• phlex/core/detail/filter_impl.cpp — Wraps output_dummy and for_output_only_queries in a function returning product_queries const&. Also fixes a latent bug: the original return-by-value caused data_map::input_products_ to point to a destroyed temporary.

• phlex/model/data_layer_hierarchy.cpp — Moves unnamed into maybe_name() as a static std::string const.

• form/root_storage/root_tbranch_write_container.cpp — Moves typeNameToLeafList from namespace scope into setupWrite(). Map remains non-const with operator[] access: an unmapped fundamental type produces an empty leaf list, which ROOT silently treats as Float_t — this is intentional.

• scripts/clang_tidy_fixes_to_problems.py — Fixes ruff I001/D101/D103 issues (import order, missing docstrings).

• test/filter_impl.cpp — Adds "Data map for output only" test exercising data_map(for_output_t) to cover the new for_output_only() function.

• test/data_cell_counting.cpp — Adds "Data layer hierarchy with unnamed layer" test; a child with an empty layer name triggers the maybe_name("") → "(unnamed)" path via the destructor's graph_layout() call.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
+ Coverage   85.49%   85.58%   +0.08%     
==========================================
  Files         142      142              
  Lines        3586     3601      +15     
  Branches      615      616       +1     
==========================================
+ Hits         3066     3082      +16     
+ Misses        311      310       -1     
  Partials      209      209              

Flag	Coverage Δ
unittests	85.58% <100.00%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
form/root_storage/root_tbranch_write_container.cpp	79.36% <100.00%> (+3.89%)	⬆️
phlex/core/detail/filter_impl.cpp	97.82% <100.00%> (+2.58%)	⬆️
phlex/model/data_layer_hierarchy.cpp	100.00% <100.00%> (+1.81%)	⬆️

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e67db...7b48c74. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[greenc-FNAL]

@phlexbot tidy-fix -* bugprone-throwing-static-initialization

[github-actions]

No automatic clang-tidy fixes were necessary.

[greenc-FNAL]

@phlexbot tidy-fix -* bugprone-throwing-static-initialization

[github-actions]

No automatic clang-tidy fixes were necessary.

[greenc-FNAL]

@copilot Please fix the ruff issues identified in https://github.com/Framework-R-D/phlex/actions/runs/24050124627/job/70143404406?pr=472

[Copilot]

Pull request overview

This PR addresses clang-tidy’s bugprone-throwing-static-initialization warnings by removing or deferring non-trivial static initialization in a few translation units and tests.

Changes:

• Replaced inline std::string test constants with constexpr char const* and updated call sites to construct std::string where required.
• Moved namespace-scope/static initializations to function-local statics (or fixtures) to avoid static initialization before main().
• Refactored a ROOT leaf-list type mapping table from namespace scope into setupWrite().

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/form/test_utils.hpp	Uses constexpr C-string literals for test file/tree names and adjusts string concatenation/calls accordingly.
test/data_cell_counting.cpp	Defers _idq.hash initialization via a Catch2 fixture helper.
phlex/model/data_layer_hierarchy.cpp	Reworks unnamed-layer formatting helper to avoid non-local static initialization.
phlex/core/detail/filter_impl.cpp	Replaces namespace-scope statics with a helper function for output-only query defaults.
form/root_storage/root_tbranch_write_container.cpp	Moves the type-to-leaf-list map into setupWrite() as a function-local static.

[greenc-FNAL]

@copilot Please add/augment tests as necessary to resolve the coverage gaps introduced by this PR as reported at https://github.com/Framework-R-D/phlex/pull/472/checks?check_run_id=70336551759

[Copilot]

@copilot Please add/augment tests as necessary to resolve the coverage gaps introduced by this PR as reported at https://github.com/Framework-R-D/phlex/pull/472/checks?check_run_id=70336551759

Added two new tests in 2c39c2d:

• "Data map for output only" in test/filter_impl.cpp — exercises data_map(for_output_t) to cover the new for_output_only() function (5 missing lines in phlex/core/detail/filter_impl.cpp).
• "Data layer hierarchy with unnamed layer" in test/data_cell_counting.cpp — creates a child layer with an empty name, which triggers the maybe_name("") → "(unnamed)" branch in phlex/model/data_layer_hierarchy.cpp (the 1 partial line) via the destructor's print() → graph_layout() → pretty_recurse() call chain.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• app.codecov.io
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.