Skip to content

Revert "Hide generated source files from clang-tidy"#474

Closed
knoepfel wants to merge 1 commit intomainfrom
revert-471-maintenance/fix-no-clang-tidy
Closed

Revert "Hide generated source files from clang-tidy"#474
knoepfel wants to merge 1 commit intomainfrom
revert-471-maintenance/fix-no-clang-tidy

Conversation

@knoepfel
Copy link
Copy Markdown
Member

Reverts #471

Seeing this failure with #471 on macOS:

cmake --build /Users/kyleknoepfel/work/phlex-devel/build

[51/256] Building CXX object phlex/phlex/app/CMakeFiles/version_obj.dir/version.cpp.o                                 
FAILED: [code=1] phlex/phlex/app/CMakeFiles/version_obj.dir/version.cpp.o 
/usr/bin/clang++  -I/Users/kyleknoepfel/work/phlex-devel/srcs -I/Users/kyleknoepfel/work/phlex-devel/build/include -O3 -fno-omno-omit-frame-pointer -g -DNDEBUG -std=c++2b -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/McS.ltiacOSX.platform/Developer/SDKs/MacOSX26.4.sdk -mmacosx-version-min=26.3 -fPIC -Wall -Werror -Wunused -Wunused-parameter -pai- Tot-frame-pointer -g -DNDEBUG edantic -MD -MT phlex/phlex/app/CMakeFiles/version_obj.dir/version.cpp.o -MF phlex/phlex/app/CMakeFiles/version_obj.dir/vico-hh/DelerDKacO6.4 -mm-versin=26-std=c++2b -arch arm64 -isysroot /Applications/Xersion.cpp.o.d -o phlex/phlex/app/CMakeFiles/version_obj.dir/version.cpp.o -c /Users/kyleknoepfel/work/phlex-devel/build/xepsc/phapakeson_r/vpp.o/phleeFileIC -Waror -WuWunusedr -pedantT phlex/pMakeFiles/code.app/Contents/Developer/Platforms/Mphlex/phlex/app/version.cpp
/Users/kyleknoepfel/work/phlex-devel/build/phlex/phlex/app/version.cpp:1:10: fatal error: 'phlex/app/version.hpp' file not fount found
    1 | #include "phlex/app/version.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[64/256] Building CXX object phlex/phlex/core/CMakeFiles/phlex_core.dir/framework_graph.cpp.o                         
ninja: build stopped: subcommand failed.

@knoepfel knoepfel requested a review from greenc-FNAL March 30, 2026 21:45
@knoepfel
Copy link
Copy Markdown
Member Author

I think I have a solution for this problem

@knoepfel knoepfel closed this Mar 30, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   85.43%   85.40%   -0.03%     
==========================================
  Files         144      144              
  Lines        3591     3591              
  Branches      615      615              
==========================================
- Hits         3068     3067       -1     
  Misses        315      315              
- Partials      208      209       +1     
Flag Coverage Δ
unittests 85.40% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a2dab...fcd0438. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel deleted the revert-471-maintenance/fix-no-clang-tidy branch April 2, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant