Skip to content

Minor symbol hiding adjustments #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greenc-FNAL merged 2 commits into from
Apr 2, 2026
Merged

Minor symbol hiding adjustments #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a27a020
Tweak for MPD support
knoepfel Apr 2, 2026
58f4414
Disable -fno-semantic-interposition for Apple
knoepfel Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Modules/private/PhlexOptimization.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,13 @@ include(CheckCXXCompilerFlag)

# Probe flag availability once at module-load time (results are cached in the
# CMake cache and reused across reconfigures).
check_cxx_compiler_flag("-fno-semantic-interposition" PHLEX_CXX_HAVE_NO_SEMANTIC_INTERPOSITION)

if(NOT APPLE)
check_cxx_compiler_flag("-fno-plt" PHLEX_CXX_HAVE_NO_PLT)

# Apple/Clang accepts -fno-semantic-interposition but the Apple toolchain
# driver treats it as unused for Mach-O builds.
check_cxx_compiler_flag("-fno-semantic-interposition" PHLEX_CXX_HAVE_NO_SEMANTIC_INTERPOSITION)
Comment thread
greenc-FNAL marked this conversation as resolved.
endif()

# ---------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion phlex/app/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ add_library(version_obj OBJECT version.cpp)
# version.cpp is generated into the build directory; clang-tidy cannot find
# .clang-tidy by walking the build-dir path, so disable linting for this file.
set_target_properties(version_obj PROPERTIES CXX_CLANG_TIDY "" POSITION_INDEPENDENT_CODE TRUE)
target_include_directories(version_obj PRIVATE ${PROJECT_SOURCE_DIR} ${CMAKE_BINARY_DIR}/include)
target_include_directories(version_obj PRIVATE ${PROJECT_SOURCE_DIR} ${PROJECT_BINARY_DIR}/include)
Comment thread
greenc-FNAL marked this conversation as resolved.

cet_make_library(
LIBRARY_NAME
Expand Down
Loading