Skip to content

Disable intermittently-failing different_hierarchies test#488

Merged
greenc-FNAL merged 1 commit intomainfrom
maintenance/disable-different_hierarchies-test
Apr 7, 2026
Merged

Disable intermittently-failing different_hierarchies test#488
greenc-FNAL merged 1 commit intomainfrom
maintenance/disable-different_hierarchies-test

Conversation

@greenc-FNAL
Copy link
Copy Markdown
Contributor

See #359

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables the intermittently failing different_hierarchies unit test in the CMake-based test registration, pending the fix tracked in issue #359 (“Change fold-result caching to use multilayer_join_node”).

Changes:

  • Removes different_hierarchies from the active cet_test(...) list by wrapping its registration in an always-false CMake conditional.
  • Adds an inline comment referencing the tracking issue for re-enabling the test once resolved.

Comment thread test/CMakeLists.txt
@greenc-FNAL greenc-FNAL merged commit 32f9b66 into main Apr 7, 2026
36 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   85.52%   85.44%   -0.09%     
==========================================
  Files         142      142              
  Lines        3586     3586              
  Branches      615      615              
==========================================
- Hits         3067     3064       -3     
- Misses        310      311       +1     
- Partials      209      211       +2     
Flag Coverage Δ
unittests 85.44% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 155a156...3a891c2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel deleted the maintenance/disable-different_hierarchies-test branch April 7, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants