Disable intermittently-failing different_hierarchies test#488
Merged
greenc-FNAL merged 1 commit intomainfrom Apr 7, 2026
Merged
Disable intermittently-failing different_hierarchies test#488greenc-FNAL merged 1 commit intomainfrom
different_hierarchies test#488greenc-FNAL merged 1 commit intomainfrom
Conversation
knoepfel
approved these changes
Apr 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Disables the intermittently failing different_hierarchies unit test in the CMake-based test registration, pending the fix tracked in issue #359 (“Change fold-result caching to use multilayer_join_node”).
Changes:
- Removes
different_hierarchiesfrom the activecet_test(...)list by wrapping its registration in an always-false CMake conditional. - Adds an inline comment referencing the tracking issue for re-enabling the test once resolved.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #488 +/- ##
==========================================
- Coverage 85.52% 85.44% -0.09%
==========================================
Files 142 142
Lines 3586 3586
Branches 615 615
==========================================
- Hits 3067 3064 -3
- Misses 310 311 +1
- Partials 209 211 +2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #359