Skip to content

clang-tidy: resolve modernize-use-nullptr #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knoepfel merged 3 commits into from
May 14, 2026
Merged

clang-tidy: resolve modernize-use-nullptr #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00eada5
`clang-tidy`: resolve `modernize-use-nullptr`
greenc-FNAL May 14, 2026
2c061b2
Update doc with `clang-tidy` progress
greenc-FNAL May 14, 2026
96058d2
Fix comment alignment
knoepfel May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/dev/clang-tidy-fixes-2026-04.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@
- [ ] [modernize-use-designated-initializers](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-designated-initializers.html) (69)
- [ ] [modernize-use-equals-default](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html) (7)
- [ ] [modernize-use-integer-sign-comparison](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-integer-sign-comparison.html) (7)
- [ ] [modernize-use-nullptr](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-nullptr.html) (194)
- [x] [modernize-use-nullptr](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-nullptr.html) (194)
- [PR #592](https://github.com/Framework-R-D/phlex/pull/592)
- [ ] [modernize-use-ranges](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-ranges.html) (5)
- [ ] [modernize-use-starts-ends-with](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-starts-ends-with.html) (6)
- [ ] [modernize-use-std-numbers](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-std-numbers.html) (2)
Expand Down
72 changes: 36 additions & 36 deletions plugins/python/src/configwrap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,56 +226,56 @@ PyTypeObject phlex::experimental::PhlexConfig_Type = {
0, // tp_itemsize
reinterpret_cast<destructor>(pcm_dealloc), // tp_dealloc
0, // tp_vectorcall_offset / tp_print
0, // tp_getattr
0, // tp_setattr
0, // tp_as_async / tp_compare
0, // tp_repr
0, // tp_as_number
0, // tp_as_sequence
nullptr, // tp_getattr
nullptr, // tp_setattr
nullptr, // tp_as_async / tp_compare
nullptr, // tp_repr
nullptr, // tp_as_number
nullptr, // tp_as_sequence
&pcm_as_mapping, // tp_as_mapping
0, // tp_hash
0, // tp_call
0, // tp_str
0, // tp_getattro
0, // tp_setattro
0, // tp_as_buffer
nullptr, // tp_hash
nullptr, // tp_call
nullptr, // tp_str
nullptr, // tp_getattro
nullptr, // tp_setattro
nullptr, // tp_as_buffer
Py_TPFLAGS_DEFAULT, // tp_flags
"phlex configuration object-as-dictionary", // tp_doc
0, // tp_traverse
0, // tp_clear
0, // tp_richcompare
nullptr, // tp_traverse
nullptr, // tp_clear
nullptr, // tp_richcompare
0, // tp_weaklistoffset
0, // tp_iter
0, // tp_iternext
0, // tp_methods
0, // tp_members
0, // tp_getset
0, // tp_base
0, // tp_dict
0, // tp_descr_get
0, // tp_descr_set
nullptr, // tp_iter
nullptr, // tp_iternext
nullptr, // tp_methods
nullptr, // tp_members
nullptr, // tp_getset
nullptr, // tp_base
nullptr, // tp_dict
nullptr, // tp_descr_get
nullptr, // tp_descr_set
offsetof(py_config_map, ph_config_cache), // tp_dictoffset
0, // tp_init
0, // tp_alloc
nullptr, // tp_init
nullptr, // tp_alloc
reinterpret_cast<newfunc>(pcm_new), // tp_new
0, // tp_free
0, // tp_is_gc
0, // tp_bases
0, // tp_mro
0, // tp_cache
0, // tp_subclasses
0 // tp_weaklist
nullptr, // tp_free
nullptr, // tp_is_gc
nullptr, // tp_bases
nullptr, // tp_mro
nullptr, // tp_cache
nullptr, // tp_subclasses
nullptr // tp_weaklist
#if PY_VERSION_HEX >= 0x02030000
, 0 // tp_del
, nullptr // tp_del
#endif
#if PY_VERSION_HEX >= 0x02060000
, 0 // tp_version_tag
#endif
#if PY_VERSION_HEX >= 0x03040000
, 0 // tp_finalize
, nullptr // tp_finalize
#endif
#if PY_VERSION_HEX >= 0x03080000
, 0 // tp_vectorcall
, nullptr // tp_vectorcall
#endif
#if PY_VERSION_HEX >= 0x030c0000
, 0 // tp_watched
Expand Down
76 changes: 38 additions & 38 deletions plugins/python/src/dciwrap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,58 +42,58 @@ PyTypeObject phlex::experimental::PhlexDataCellIndex_Type = {
"pyphlex.data_cell_index", // tp_name
sizeof(py_data_cell_index), // tp_basicsize
0, // tp_itemsize
0, // tp_dealloc
nullptr, // tp_dealloc
0, // tp_vectorcall_offset / tp_print
0, // tp_getattr
0, // tp_setattr
0, // tp_as_async / tp_compare
0, // tp_repr
0, // tp_as_number
0, // tp_as_sequence
0, // tp_as_mapping
0, // tp_hash
0, // tp_call
0, // tp_str
0, // tp_getattro
0, // tp_setattro
0, // tp_as_buffer
nullptr, // tp_getattr
nullptr, // tp_setattr
nullptr, // tp_as_async / tp_compare
nullptr, // tp_repr
nullptr, // tp_as_number
nullptr, // tp_as_sequence
nullptr, // tp_as_mapping
nullptr, // tp_hash
nullptr, // tp_call
nullptr, // tp_str
nullptr, // tp_getattro
nullptr, // tp_setattro
nullptr, // tp_as_buffer
Py_TPFLAGS_DEFAULT, // tp_flags
"phlex data_cell_index", // tp_doc
0, // tp_traverse
0, // tp_clear
0, // tp_richcompare
nullptr, // tp_traverse
nullptr, // tp_clear
nullptr, // tp_richcompare
0, // tp_weaklistoffset
0, // tp_iter
0, // tp_iternext
nullptr, // tp_iter
nullptr, // tp_iternext
dci_methods, // tp_methods
0, // tp_members
0, // tp_getset
0, // tp_base
0, // tp_dict
0, // tp_descr_get
0, // tp_descr_set
nullptr, // tp_members
nullptr, // tp_getset
nullptr, // tp_base
nullptr, // tp_dict
nullptr, // tp_descr_get
nullptr, // tp_descr_set
0, // tp_dictoffset
0, // tp_init
0, // tp_alloc
0, // tp_new
0, // tp_free
0, // tp_is_gc
0, // tp_bases
0, // tp_mro
0, // tp_cache
0, // tp_subclasses
0 // tp_weaklist
nullptr, // tp_init
nullptr, // tp_alloc
nullptr, // tp_new
nullptr, // tp_free
nullptr, // tp_is_gc
nullptr, // tp_bases
nullptr, // tp_mro
nullptr, // tp_cache
nullptr, // tp_subclasses
nullptr // tp_weaklist
#if PY_VERSION_HEX >= 0x02030000
, 0 // tp_del
, nullptr // tp_del
#endif
#if PY_VERSION_HEX >= 0x02060000
, 0 // tp_version_tag
#endif
#if PY_VERSION_HEX >= 0x03040000
, 0 // tp_finalize
, nullptr // tp_finalize
#endif
#if PY_VERSION_HEX >= 0x03080000
, 0 // tp_vectorcall
, nullptr // tp_vectorcall
#endif
#if PY_VERSION_HEX >= 0x030c0000
, 0 // tp_watched
Expand Down
70 changes: 35 additions & 35 deletions plugins/python/src/lifelinewrap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,56 +52,56 @@ PyTypeObject phlex::experimental::PhlexLifeline_Type = {
0, // tp_itemsize
reinterpret_cast<destructor>(ll_dealloc), // tp_dealloc
0, // tp_vectorcall_offset / tp_print
0, // tp_getattr
0, // tp_setattr
0, // tp_as_async / tp_compare
0, // tp_repr
0, // tp_as_number
0, // tp_as_sequence
0, // tp_as_mapping
0, // tp_hash
0, // tp_call
0, // tp_str
0, // tp_getattro
0, // tp_setattro
0, // tp_as_buffer
nullptr, // tp_getattr
nullptr, // tp_setattr
nullptr, // tp_as_async / tp_compare
nullptr, // tp_repr
nullptr, // tp_as_number
nullptr, // tp_as_sequence
nullptr, // tp_as_mapping
nullptr, // tp_hash
nullptr, // tp_call
nullptr, // tp_str
nullptr, // tp_getattro
nullptr, // tp_setattro
nullptr, // tp_as_buffer
Py_TPFLAGS_DEFAULT | Py_TPFLAGS_HAVE_GC, // tp_flags
"internal", // tp_doc
reinterpret_cast<traverseproc>(ll_traverse), // tp_traverse
reinterpret_cast<inquiry>(ll_clear), // tp_clear
0, // tp_richcompare
nullptr, // tp_richcompare
0, // tp_weaklistoffset
0, // tp_iter
0, // tp_iternext
0, // tp_methods
0, // tp_members
0, // tp_getset
0, // tp_base
0, // tp_dict
0, // tp_descr_get
0, // tp_descr_set
nullptr, // tp_iter
nullptr, // tp_iternext
nullptr, // tp_methods
nullptr, // tp_members
nullptr, // tp_getset
nullptr, // tp_base
nullptr, // tp_dict
nullptr, // tp_descr_get
nullptr, // tp_descr_set
0, // tp_dictoffset
0, // tp_init
0, // tp_alloc
nullptr, // tp_init
nullptr, // tp_alloc
reinterpret_cast<newfunc>(ll_new), // tp_new
0, // tp_free
0, // tp_is_gc
0, // tp_bases
0, // tp_mro
0, // tp_cache
0, // tp_subclasses
0 // tp_weaklist
nullptr, // tp_free
nullptr, // tp_is_gc
nullptr, // tp_bases
nullptr, // tp_mro
nullptr, // tp_cache
nullptr, // tp_subclasses
nullptr // tp_weaklist
#if PY_VERSION_HEX >= 0x02030000
, 0 // tp_del
, nullptr // tp_del
#endif
#if PY_VERSION_HEX >= 0x02060000
, 0 // tp_version_tag
#endif
#if PY_VERSION_HEX >= 0x03040000
, 0 // tp_finalize
, nullptr // tp_finalize
#endif
#if PY_VERSION_HEX >= 0x03080000
, 0 // tp_vectorcall
, nullptr // tp_vectorcall
#endif
#if PY_VERSION_HEX >= 0x030c0000
, 0 // tp_watched
Expand Down
Loading
Loading