Handles are valid upon construction #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 81.72% 81.91% +0.19%
==========================================
Files 118 118
Lines 2079 2074 -5
Branches 336 336
==========================================
Hits 1699 1699
+ Misses 246 243 -3
+ Partials 134 132 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
knoepfel
force-pushed
the
handles-always-valid
branch
from
fa6b302 to
0e7bc1e
Compare
pcanal
reviewed
Nov 6, 2025
pcanal
reviewed
Nov 6, 2025
knoepfel
force-pushed
the
handles-always-valid
branch
2 times, most recently
from
51e36ed to
a2ff1c6
Compare
pcanal
reviewed
Nov 10, 2025
knoepfel
force-pushed
the
handles-always-valid
branch
from
a2ff1c6 to
b513dd1
Compare
Member
Author
|
@pcanal, do you have any more comments on this PR? |
pcanal
reviewed
Nov 12, 2025
knoepfel
force-pushed
the
handles-always-valid
branch
2 times, most recently
from
b9b19b0 to
74acc1a
Compare
greenc-FNAL
force-pushed
the
handles-always-valid
branch
from
74acc1a to
f46b07a
Compare
knoepfel
force-pushed
the
handles-always-valid
branch
from
f46b07a to
ce820b1
Compare
Member
Author
|
@pcanal, I believe I've addressed the issues you've raised. Is there anything else I should address before approving this PR? |
pcanal
reviewed
Nov 13, 2025
Includes: - Restricting handle template argument types and how they are selected - Removing unnecessary constructors - Explicit tests of handle comparisons - Specifications of handle's special member functions
greenc-FNAL
force-pushed
the
handles-always-valid
branch
from
ce820b1 to
2a956fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the behaviors expected of a handle as discussed here. The critical item is that a constructed handle object is always valid in Phlex—there is no need for default-constructed handles as a handle always provides access to one (and only one) data product.