Merged
Conversation
Signed-off-by: Daniel Schaefer <dhs@frame.work>
Type-C state is the state of the port partner. And hide that information if no PD contract. Signed-off-by: Daniel Schaefer <dhs@frame.work>
- VCONN and Negotiated only makes sense if there's a connection - On top of that Port Partner role, EPR and sink active only makes sense with pd contract - Rename Active Port to Sink Active to be clearer Signed-off-by: Daniel Schaefer <dhs@frame.work>
There was a problem hiding this comment.
Pull request overview
This PR clarifies the framework_tool --pdports output by only printing connection/contract-specific fields when they’re meaningful, and updates the documentation examples to match the new output format.
Changes:
- Update
--pdportsoutput formatting: show negotiated/VCONN/CC details only when a port is connected; show EPR/partner/active-sink only when a PD contract exists. - Rename the previously confusing “Type-C State” output to “Port Partner” (shown only when a PD contract exists) and rename “Active Port” to “Sink Active” (only for sink role).
- Refresh
EXAMPLES.md--pdportssection with updated excerpts and an explicit invocation snippet.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| framework_lib/src/power.rs | Adjusts --pdports printing logic to conditionally display fields and clarify labels. |
| EXAMPLES.md | Updates --pdports documentation and sample outputs to reflect the new formatting/labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.