ledmatrix: Automatically go to sleep and enable sleep/wake commands #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means the software sleep control will work again. Hardware sleep control won't override it. See README for details. Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
Keep the device awake if the user interacts with it. Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
commented
Aug 2, 2023
ledmatrix/README.md
Outdated
| - Sleep/Wake Command via USB Serial | ||
| - Idle timer | ||
|
|
||
| Both of the hardware triggers change the sleep state if the transition from one state to another. |
Member
Author
There was a problem hiding this comment.
Suggested change
| Both of the hardware triggers change the sleep state if the transition from one state to another. | |
| Both of the hardware triggers change the sleep state if they transition from one state to another. |
JohnAZoidberg
commented
Aug 2, 2023
Signed-off-by: Daniel Schaefer <dhs@frame.work>
It's annoying to use the wake up command. Any command should wake up the module. Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
autosleep
branch
from
06e0a1e to
51206ac
Compare
Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
commented
Aug 8, 2023
ledmatrix/src/main.rs
Outdated
| Ok(count) => { | ||
| let random = get_random_byte(&rosc); | ||
| match (parse_command(count, &buf), &state.sleeping) { | ||
| // While sleeping no command is handled, except waking up |
Member
Author
There was a problem hiding this comment.
Suggested change
| // While sleeping no command is handled, except waking up |
Waking up should resume to the newly set brightness. And it should also immediately show the newly set grid, not just ignore it. Waking up command should also reset the sleep timer. Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change sleep only if state changed or should sleep
This means the software sleep control will work again. Hardware sleep
control won't override it.
See README for detailed description of new sleep behavior.