-
Notifications
You must be signed in to change notification settings - Fork 82
Update Dependency Versions #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
============================================
+ Coverage 45.89% 46.75% +0.86%
- Complexity 331 337 +6
============================================
Files 64 64
Lines 1743 1743
Branches 125 125
============================================
+ Hits 800 815 +15
+ Misses 874 854 -20
- Partials 69 74 +5
Continue to review full report at Codecov.
|
pom.xml
Outdated
| <artifactId>truth</artifactId> | ||
| <version>0.42</version> | ||
| <!--Version 1.0 is expected to release on July 8--> | ||
| <version>0.46</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now you've added a property for truth.version you can use it here and below by ${truth.version}
|
|
||
| assertThat(headings) | ||
| .named("Order of headings") | ||
| // Method named() has been depreciated. Unsure if this is a viable fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (please remove commented out code/question)
pom.xml
Outdated
| <dependency> | ||
| <groupId>com.puppycrawl.tools</groupId> | ||
| <artifactId>checkstyle</artifactId> | ||
| <!--The 8.18 to 8.22 upgrade requires curly brackets '{}' to be on separate lines. Many modules will need to be checked for this. Please advise to change or not?--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the doc/style/style.xml file, from line 63, we can replace:
<module name="RightCurly"/>
<module name="RightCurly">
<property name="option" value="alone"/>
<property name="tokens"
value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/>
</module>
with
<module name="RightCurly">
<property name="option" value="alone"/>
<property name="tokens"
value="CLASS_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/>
</module>
No description provided.