Skip to content

Conversation

@alex-ogedengbe
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #141 into master will increase coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #141      +/-   ##
============================================
+ Coverage     45.89%   46.75%   +0.86%     
- Complexity      331      337       +6     
============================================
  Files            64       64              
  Lines          1743     1743              
  Branches        125      125              
============================================
+ Hits            800      815      +15     
+ Misses          874      854      -20     
- Partials         69       74       +5
Impacted Files Coverage Δ Complexity Δ
...um/core/common/listeners/ResultLoggerListener.java 31.2% <0%> (+4.25%) 18% <0%> (+3%) ⬆️
...meworkium/core/ui/listeners/SauceLabsListener.java 30.43% <0%> (+4.34%) 6% <0%> (+1%) ⬆️
...ameworkium/core/common/listeners/TestListener.java 86.36% <0%> (+36.36%) 8% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87cdcc...733af64. Read the comment docs.

pom.xml Outdated
<artifactId>truth</artifactId>
<version>0.42</version>
<!--Version 1.0 is expected to release on July 8-->
<version>0.46</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you've added a property for truth.version you can use it here and below by ${truth.version}


assertThat(headings)
.named("Order of headings")
// Method named() has been depreciated. Unsure if this is a viable fix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (please remove commented out code/question)

pom.xml Outdated
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<!--The 8.18 to 8.22 upgrade requires curly brackets '{}' to be on separate lines. Many modules will need to be checked for this. Please advise to change or not?-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the doc/style/style.xml file, from line 63, we can replace:

        <module name="RightCurly"/>
        <module name="RightCurly">
            <property name="option" value="alone"/>
            <property name="tokens"
                      value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/>
        </module>

with

        <module name="RightCurly">
            <property name="option" value="alone"/>
            <property name="tokens"
                      value="CLASS_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/>
        </module>

@ham1 ham1 changed the title Mvncmdfix Update Dependency Versions Jul 4, 2019
@ham1 ham1 merged commit e315bf6 into Frameworkium:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants