Skip to content

Conversation

@ham1
Copy link
Member

@ham1 ham1 commented Dec 28, 2017

  • Removed DesiredCapabilities from Driver interface, replaced with Capabilities
  • Changed method names in Driver interface to reflect change in return type
  • Used XyzOptions e.g. FirefoxOptions rather than pure Capabilities
  • Upgraded checkstyle from 8.3 to 8.5

@ham1 ham1 force-pushed the remove-desired-caps branch from a3cc2e1 to 9ff37f6 Compare December 28, 2017 05:24
@codecov
Copy link

codecov bot commented Dec 28, 2017

Codecov Report

Merging #93 into master will decrease coverage by 0.09%.
The diff coverage is 12.59%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #93     +/-   ##
===========================================
- Coverage     36.67%   36.58%   -0.1%     
+ Complexity      274      273      -1     
===========================================
  Files            59       59             
  Lines          1775     1774      -1     
  Branches        167      169      +2     
===========================================
- Hits            651      649      -2     
- Misses         1037     1039      +2     
+ Partials         87       86      -1
Impacted Files Coverage Δ Complexity Δ
...eworkium/core/ui/driver/drivers/PhantomJSImpl.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/com/frameworkium/core/ui/driver/Driver.java 50% <ø> (ø) 1 <0> (ø) ⬇️
...frameworkium/core/ui/driver/drivers/OperaImpl.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...meworkium/core/ui/driver/drivers/ElectronImpl.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...kium/core/ui/driver/drivers/LegacyFirefoxImpl.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rkium/core/ui/driver/drivers/BrowserStackImpl.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...frameworkium/core/ui/driver/drivers/SauceImpl.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rameworkium/core/ui/driver/drivers/SafariImpl.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...m/core/ui/driver/drivers/InternetExplorerImpl.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rkium/core/ui/driver/drivers/WinAppDriverImpl.java 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d0845d...395919a. Read the comment docs.

@ham1 ham1 force-pushed the remove-desired-caps branch from e9f31d2 to 395919a Compare December 28, 2017 17:59
@ham1 ham1 merged commit 3aa4913 into master Dec 29, 2017
@ham1 ham1 deleted the remove-desired-caps branch December 29, 2017 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants