-
Notifications
You must be signed in to change notification settings - Fork 0
Split CI/CD pipeline into separate test and publish jobs with comprehensive template validation #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Frantche <21145306+Frantche@users.noreply.github.com>
Co-authored-by: Frantche <21145306+Frantche@users.noreply.github.com>
Co-authored-by: Frantche <21145306+Frantche@users.noreply.github.com>
Co-authored-by: Frantche <21145306+Frantche@users.noreply.github.com>
…esting and main deployment Co-authored-by: Frantche <21145306+Frantche@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…matting fixes Co-authored-by: Frantche <21145306+Frantche@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…ompatibility Co-authored-by: Frantche <21145306+Frantche@users.noreply.github.com>
Co-authored-by: Frantche <21145306+Frantche@users.noreply.github.com>
Co-authored-by: Frantche <21145306+Frantche@users.noreply.github.com>
Co-authored-by: Frantche <21145306+Frantche@users.noreply.github.com>
…lity Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…lity Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…o multiple lines Co-authored-by: Frantche <21145306+Frantche@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR restructures the CI/CD pipeline to implement a two-job architecture that separates testing for pull requests from production deployment on the main branch. The changes enhance the validation process and provide comprehensive testing of Coder templates before production deployment.
- Split single job into separate test and publish workflows for better separation of concerns
- Added comprehensive Terraform validation and template deployment testing for PRs
- Introduced temporary resource naming with automatic cleanup for test environments
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/coder-template-update.yaml |
Complete restructure into separate test and publish jobs with enhanced validation and cleanup |
validate.sh |
New local validation script for Terraform template testing |
This PR implements a streamlined CI/CD pipeline that separates PR testing from production deployment using two distinct GitHub Actions jobs. The solution follows Coder's recommended patterns while providing comprehensive testing and proper resource management.
Key Changes
Two-Job Architecture:
ci-{short_sha}naming, and performs automatic cleanupEnhanced Testing Pipeline:
terraform init,terraform fmt -check -diffand validationkubernetes-ci-{short_sha})cpu=2,memory=2,home_disk_size=10)Production Deployment:
namespace=coder-workspaceCode Quality Improvements:
-d template-kubernetesoptionThe workflow ensures templates are syntactically correct, properly formatted, and can be successfully deployed before merging, while maintaining clean separation between test and production environments.
Fixes #14.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.